Skip to content

Improve change detection#304

Merged
martinkrivda merged 3 commits intomainfrom
bugfix/invalid-change-detection
Apr 28, 2026
Merged

Improve change detection#304
martinkrivda merged 3 commits intomainfrom
bugfix/invalid-change-detection

Conversation

@lukaskett
Copy link
Copy Markdown
Contributor

fix: added check if the new value is really changed, used crateMany for protocol insert (instead of await for loop), #124

Summary

  • Describe the scope of the change.
  • Link the related issue if one exists.

Checklist

  • I linked the related issue or explained why none is needed.
  • I ran the relevant checks for this change.
  • I updated documentation or changelog entries when needed.
  • By submitting this pull request, I agree to the terms in CLA.md in the
    repository root.

@martinkrivda
Copy link
Copy Markdown
Collaborator

@lukaskett The additional change needed was to handle lateStart as its own persisted value in changeCompetitorStatus.

The previous fix only checked whether status changed before writing a protocol entry. That missed the LateStart
flow, because LateStart is stored as status = Active plus lateStart = true. So when a competitor was already
Active, the status comparison saw no change and skipped protocol logging, even though lateStart actually
changed.

@martinkrivda martinkrivda merged commit 076f74e into main Apr 28, 2026
1 of 3 checks passed
@martinkrivda martinkrivda deleted the bugfix/invalid-change-detection branch April 28, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants